search

pavanagrawal123 / VSNotebooks

Jupyter Notebooks in Visual Studio Code
MIT License
63 stars 2 forks source link

fixed remoteKernel doesn't load #31

Closed allenyllee closed 5 years ago

allenyllee commented 5 years ago

In the package.json, the configuration block defines properties "VSNotebooks.remoteKernel", "VSNotebooks.remoteKernelAddress" and "VSNotebooks.remoteKernelToken", but not "VSNotebooks.setting.remoteKernel", "VSNotebooks.setting.remoteKernelAddress" and "VSNotebooks.setting.remoteKernelToken". This fixed it.

pavanagrawal123 commented 5 years ago

Thank you so much for submitting a PR! I’ll review in a few hours! :)

Get Outlook for iOShttps://aka.ms/o0ukef

From: Allen.YL notifications@github.com Sent: Wednesday, February 27, 2019 2:14 AM To: pavanagrawal123/VSNotebooks Cc: Subscribed Subject: [pavanagrawal123/VSNotebooks] fixed remoteKernel doesn't load (#31)

In the package.json, the configuration block defines properties "VSNotebooks.remoteKernel", "VSNotebooks.remoteKernelAddress" and "VSNotebooks.remoteKernelToken", but not "VSNotebooks.setting.remoteKernel", "VSNotebooks.setting.remoteKernelAddress" and "VSNotebooks.setting.remoteKernelToken". This fixed it.

You can view, comment on, or merge this pull request online at:

https://github.com/pavanagrawal123/VSNotebooks/pull/31

Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/pavanagrawal123/VSNotebooks/pull/31, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQ-mpUrgnfBv1DTCLMaMtE0nT77paMv_ks5vRj56gaJpZM4bT8RU.