pavanagrawal123 / VSNotebooks

Jupyter Notebooks in Visual Studio Code
MIT License
63 stars 2 forks source link

fixed "Open in Browser" can't open exported ipynb in remote kernel #32

Closed allenyllee closed 5 years ago

allenyllee commented 5 years ago

If you have remote kernel running on your local, you'll find that you cannot open exported ipynb in your browser. This is because there are no file path information passed into openNotebookInBrowser(). This fixed it.

pavanagrawal123 commented 5 years ago

@allenyllee This looks pretty good on first review, but I am going to a bit more testing before merging in!

pavanagrawal123 commented 5 years ago

Thank you so much for the changes @allenyllee