search

pavankataria / SwiftDataTables

A Swift Data Table package, display grid-like data sets in a nicely formatted table for iOS. Subclassing UICollectionView that allows ordering, and searching with extensible options.
MIT License
448 stars 69 forks source link

remove Pods from this repository #27

Closed altagir closed 5 years ago

altagir commented 5 years ago

I think you should remove the Example/Pods folder and Podfile.lock from this repository

-> remove Pods from repo -> remove Podfile.lock ? -> or at least update it with 0.7.0

cheers

pavankataria commented 5 years ago

I realise there's no value in adding the pods when it's just retrieving them from the source folder. It'll also make things lean and avoid an extra step of having to run pod install on the demo project. Plus it was redundant always lagging behind unless I updated after I uploaded the podspec which would cause more noisy commits.

I'll fix this in the next release. Do double check in case I leave anything out.

pavankataria commented 5 years ago

🎉 🎉 @altagir This is now available as of version 0.7.1 🎉 🎉 https://github.com/pavankataria/SwiftDataTables/releases/tag/0.7.1

Let me know what you think 🎉

altagir commented 5 years ago

you need to clean current pods used in sample (Pods/ and Podfile as well as references from project) 

cd SwiftDataTables/Example
pod deintegrate SwiftDataTables.xcodeproj
rm Podfile
pavankataria commented 5 years ago

It’s already been deintegrated along with a few other files, I used a plug-in from a cocoa pods creator; turns out doesn’t remove fake care of everything though deleting pod file etc is my responsibility. I’ll just push and change the tag commit reference

altagir commented 5 years ago

it wasn't deintegrated, was still present along with workspace in 0.7.1 I had to do above commands after a fresh pull from 0.7.1. it will clean workspace and Pods cheers

altagir commented 5 years ago

I put all 3 issues we were talking about in last 3 commits of https://github.com/altagir/SwiftDataTables/commits/master

pavankataria commented 5 years ago

You're right, it wasn't deintegrated properly. I thought everything was dereferenced when I ran the deintegrate plugin. Turns out there were a few remaining pieces left as well as the configurations inside the project.

pavankataria commented 5 years ago

Please do try again and let me know if you still see the issue. I've tried on my side and it seems everything has been cleared.

pavankataria commented 5 years ago

I'll mark this issue as complete. Can reopen if there's any further issues.

altagir commented 5 years ago

sorry for late reply, been a bit overbusy :) just verified, all perfect, thanks mate regards