search

pavankataria / SwiftDataTables

A Swift Data Table package, display grid-like data sets in a nicely formatted table for iOS. Subclassing UICollectionView that allows ordering, and searching with extensible options.
MIT License
448 stars 69 forks source link

Support the dark mode? #53

Closed yuchung-chuang closed 4 years ago

yuchung-chuang commented 4 years ago

First of all, thank you for creating such great tool for us. I'm just wondering if SwiftDataTable is able to support the dark mode? Since when using it in the dark mode, all the text in the table turns to white, while the background of the table doesn't. This makes the content completely unreadable. I've tried to add some condition like "traitCollection.userInterfaceStyle" in your source code to detect the dark mode, however, I realized that the target of your project is iOS 9, which is not supported this. Perhaps there's some other way to detect dark mode in iOS 9? Or would you mind to upgrade the target to iOS 13?

yuchung-chuang commented 4 years ago

just found out that @Anonym0uz has created a pull request which solved this issue