pavel-collab / Bachelor-Thesis-Template

Other
56 stars 24 forks source link

Makefile doesn't work!!! #18

Open pavel-collab opened 4 months ago

pavel-collab commented 4 months ago

The Makefile, you have written doesn't work. I have tested it on Ubuntu 20.04 and 22.04. The output message is "there is no targets for all" or "Make: main.pdf no such file or directory". I revised the source of Makefile, I think, it's too difficult targets for the commands. I tried to make it simple, smth like that:

.PHONY: all clean

all:
    latexrun/latexrun main.tex

clean:
    latexrun/latexrun --clean-all
    -rm -f $(PDFS)

this kind of Makefile works correctly. Please, fix it and test to insure that all is alright. One more thing. The makefile command clean works incorrect!! It has not to remove the .pdf file, only third-party build files. I really don't understand, why have you decided to write it like that. Check out the README. There you can find clear information, that by using command make clean you remove only third-party files. User apply this command to get an effect, he have read in README, but he get the different one. You have two options: you make a special commands to remove the .pdf file or you have to mark this part of functional in the README. Please, please, check the project description careful, before you starting to write a feature for it!!!

kolobabka commented 4 months ago

Hi everyone. I am going to improve current Makefile this evening. Current problem is missing any dependencies, so we need to recompile everything if we've changed only the certain file. Moreover, it doesn't recompile the target if we've already have main.pdf in root directory.

Exactlywb commented 4 months ago

Hi @kolobabka. Probably you need to add all new dependencies into configure.sh script.

kolobabka commented 4 months ago

Hi @kolobabka. Probably you need to add all new dependencies into configure.sh script.

Not this patch. Honestly, suppose user has Ubuntu (not Manjaro f.e) is already tricky. So, shall improve it later? :)

kolobabka commented 4 months ago

I recognize it's not the best Makefile in the world, but

kolobabka commented 4 months ago

Also updated README with title