search

pavel-odintsov / fastnetmon

FastNetMon - very fast DDoS sensor with sFlow/Netflow/IPFIX/SPAN support
https://fastnetmon.com
GNU General Public License v2.0
3.4k stars 562 forks source link

Fedora linter, Forbidden function symbols found: inet_addr inet_aton inet_ntoa #936

Open pavel-odintsov opened 2 years ago

pavel-odintsov commented 2 years ago

We've got following warning from Fedora's linter: https://osci-jenkins-1.ci.fedoraproject.org/job/fedora-ci/job/rpminspect-pipeline/job/master/104394/testReport/(root)/tests/_badfuncs/

The reason of such warning is well described here: https://github.com/rpminspect/rpminspect-data-fedora/blob/master/fedora.yaml#L719

I think we need to review our approach for these functions if possible.

pavel-odintsov commented 2 years ago

Examples: https://github.com/pavel-odintsov/fastnetmon/blob/bec1b5fdee40421a3fb7d099a79d93d1d6d481fe/src/sflow_plugin/sflow_collector.cpp#L210 https://github.com/pavel-odintsov/fastnetmon/blob/ce2eddca7878a36b61b5c885039f1aaa94f4f934/src/fast_library.cpp#L57 https://github.com/pavel-odintsov/fastnetmon/blob/ce2eddca7878a36b61b5c885039f1aaa94f4f934/src/fast_library.cpp#L63

pavel-odintsov commented 1 year ago

We get rid of one of them actually as part of project to port to Windows.

pavel-odintsov commented 10 months ago

One more fix in sFlow logic