pavel-pimenov / flylinkdc-r6xx

flylinkdc-r6xx
20 stars 7 forks source link

User Description duplicated when hub uses "desc_insert_mode 1". #50

Closed wiejakp closed 1 year ago

wiejakp commented 1 year ago

Verlihub returns odd data info using !userinfo USERNAME might show info including description like:

Description: [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ]

when setting these configs:

!set desc_insert_mode 1
!set desc_insert_vars [ %[CLASS] ] 

I've talked with verlihub developer and it doesn't seem to be Verlihub nor Ledokol issue, and he could replicate it with using flylink client 601.23097.

List of users who have that description: https://www.te-home.net/?do=hublist&action=seen&desc=[%200%20]%20[%200%20]&cotag=1

The description is getting long too:

[17:44:09] <# Verlihub> Users with description [ 0 ] [ 0 ] found in following hubs:

 1. Ylgy | [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] [ 0 ] bu | dchub://hub.pwiam.com:4111
RoLex commented 1 year ago

I can add that any hub software returns odd data in MyINFO with this FlylinkDC++ version. I've created a test server which is not a real DC hub server, it simply crates an environment that a DC client can use. The results are the same - FlylinkDC++ keeps storing the MyINFO sent by hub, and adding its own data to it. A DC client should never store the MyINFO sent from hub, but create its own, according to client settings.

RoLex commented 1 year ago

Fixed in build 23145