pavelbabenko / react-native-awesome-gallery

Performant, native-like, and well-customizable gallery for React Native.
MIT License
495 stars 54 forks source link

feat: added RTL support #24

Closed emadhajjar closed 2 years ago

emadhajjar commented 3 years ago

@pavelbabenko can you take a look.

pavelbabenko commented 3 years ago

Hi @aleppos I would leave the choice of enabling rtl for developer Could you make isRTL as prop of Gallery? And please, test with other props, e.g loop

FadiAboMsalam commented 2 years ago

@pavelbabenko I don't think that making a prop of isRTL is necessary since the code only affects when I18nManager.isRTL is true so this won't affect the LTR devices and would help any RTL ones like my case BTW I tested the PR and it works great @aleppos thank you

pavelbabenko commented 2 years ago

Implemented in v0.3.3