search

pavelbabenko / react-native-awesome-gallery

Performant, native-like, and well-customizable gallery for React Native.
MIT License
495 stars 54 forks source link

feat: doubleTapGesture must depend on pinchEnabled #54

Closed baronha closed 11 months ago

baronha commented 11 months ago

I think when pinchEnable === false => doubleTap for zooming should also be disabled. Or is there an alternative prop to turn this off? In my case, there is an Video Item and I don't want the user to be able to zoom into my

pavelbabenko commented 11 months ago

Hey @baronha Good catch! But it's better to introduce new prop doubleTapEnabled Will you be able to add it?

baronha commented 11 months ago

Hey @baronha Good catch! But it's better to introduce new prop doubleTapEnabled Will you be able to add it?

Sure. I'll add it and will send the PR back to you

baronha commented 11 months ago

@pavelbabenko I added doubleTapEnabled. Please review my code before merging

pavelbabenko commented 11 months ago

@baronha 1 small change and I'll merge it

pavelbabenko commented 11 months ago

@baronha released in https://github.com/pavelbabenko/react-native-awesome-gallery/releases/tag/v0.3.8