search

paveldn / haier-esphome

Haier ac integration for ESPHome
88 stars 14 forks source link

Invert display status logic #2

Closed bearpawmaxim closed 1 year ago

bearpawmaxim commented 1 year ago

In this PR I have inverted display status logic because it was working incorrectly: off in HA was on on AC and vice versa. Also, renamed packet variable disable_beeper to beeper_state also according to the protocol documentation (just a cosmetics change).

Should I also rename beeper stuff in the python part (this will lead to incompatibility on the existing setups)?

paveldn commented 1 year ago

Thanks. Yes please also change beeper things in python. It is a dev branch so work in progress. Can be a little incompatibility.