search

pavelk2 / social-feed

JavaScript plugin that shows a user feed from the most popular social networks
http://pavelk2.github.io/social-feed-example/
MIT License
962 stars 304 forks source link

HTTPS / SSL support #108

Open sebszocinski opened 9 years ago

sebszocinski commented 9 years ago

Can we get support for HTTPS / SSL or is it easy enough to just edit the plugin source and replace http with https?

pavelk2 commented 9 years ago

I believe that just changing the protocols (http -> https) should be enough, please let me know if you face any issues.

sebszocinski commented 9 years ago

Hmm ok I tried that and it seems twitter is still loading images over http...

....but requested an insecure image 'http://pbs.twimg.com/media....

stefanlesik commented 8 years ago

I'm having the same issue. Any ideas?

stefanlesik commented 8 years ago

Ok, I found it

Edit line 238

Replace var image_url = element.entities.media[0].media_url; With var image_url = element.entities.media[0].media_url.replace('http://','https://');

stefanlesik commented 8 years ago

and line 227 post.author_picture = element.user.profile_image_url.replace('http://','https://');

pavelk2 commented 8 years ago

Dear @stefanlesik,

Could you provide a pull request for this edit?

martijngastkemper commented 8 years ago

@pavelk2 @stefanlesik I've created a PR #178