pavelk2 / social-feed

JavaScript plugin that shows a user feed from the most popular social networks
http://pavelk2.github.io/social-feed-example/
MIT License
960 stars 303 forks source link

twitter still requests token when consumer_key/secret not set #120

Closed joshuaatkins closed 8 years ago

joshuaatkins commented 9 years ago

It has been observed on some installations of this plugin that where are set to empty, the plugin still attempts to open a connection and retrieve a token from twitter. This then appears to loop every second applying alot of load to the codebird-js api.

consumer_key: '', consumer_secret: ''

A check should be added, that if a key or secret is not provided no initialisation of the script is attempted.

Webarkitekt commented 9 years ago

Why do you need to keep twitter configuration parameters ? If you don't need to show twitter posts, just remove the twitter configuration.