pavelk2 / social-feed

JavaScript plugin that shows a user feed from the most popular social networks
http://pavelk2.github.io/social-feed-example/
MIT License
962 stars 304 forks source link

Bower is out of date #137

Open lewissmallmedia opened 8 years ago

lewissmallmedia commented 8 years ago

I just installed from bower and had a few problems then i re-install direct from git source and the issues disappeared. Is you bower the latest version.

Cheers,

Lewis

kamilon50 commented 8 years ago

Hello there how did you manage to install with bower ?

lewissmallmedia commented 8 years ago

yes but when looking at the code of the two jquery.socialfeed.js files (the one from github and the other from bower) they seem to differ. bower version has 564 lines and github version is 747 lines

lewissmallmedia commented 8 years ago

Also looks like the latest code for time_ago is defaulting to Italian.

I fixed on my local by simply putting moment.locale('en') at the top of the code.

Might be good to add a feature of changing default language in the settings.

kamilon50 commented 8 years ago

​Good evening Pavel

Thank you for response to my previous email :-)

Is it ok to contact you tomorrow if I will have any more difficulties ? ​

All the Best,

Kamil | CKdesign http://t.sidekickopen28.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XX43MPfv6Vd0yGC7fK95-VRJgRK56dPKmf6tNWk202?t=http%3A%2F%2Fckdesign.eu%2F&si=4632408293113856&pi=c12366d3-e0b3-45f1-c88b-44d3c9ec4186

On Wed, Nov 18, 2015 at 6:28 PM, Lewis Bellwood notifications@github.com wrote:

Also looks like the latest code for time_ago is defaulting to Italian.

I fixed on my local by simply putting moment.locale('en') at the top of the code.

Might be good to add a feature of changing default language in the settings.

— Reply to this email directly or view it on GitHub https://github.com/pavelk2/social-feed/issues/137#issuecomment-157811612 .

kamilon50 commented 8 years ago

Sorry not Pavel Lewis

All the Best,

Kamil | CKdesign http://t.sidekickopen28.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XX43MPfv6Vd0yGC7fK95-VRJgRK56dPKmf6tNWk202?t=http%3A%2F%2Fckdesign.eu%2F&si=4632408293113856&pi=54b65703-3019-4a1d-ec04-c53aa40ee325

On Wed, Nov 18, 2015 at 6:28 PM, Lewis Bellwood notifications@github.com wrote:

Also looks like the latest code for time_ago is defaulting to Italian.

I fixed on my local by simply putting moment.locale('en') at the top of the code.

Might be good to add a feature of changing default language in the settings.

— Reply to this email directly or view it on GitHub https://github.com/pavelk2/social-feed/issues/137#issuecomment-157811612 .

Webarkitekt commented 8 years ago

@lewissmallmedia to change the default moment lang you should load the moment locale you need. Check out the documentation

<!-- Moment Locale to format the date to your language (eg. italian lang)-->
<script src="bower_components/moment/locale/it.js"></script>

If you remove this line it will be set to default lang ('en')

Sorry but actually, the bower version is not up to date.

pavelk2 commented 8 years ago

We need to update the version available through Bower to close this issue