search

pavelk2 / social-feed

JavaScript plugin that shows a user feed from the most popular social networks
http://pavelk2.github.io/social-feed-example/
MIT License
960 stars 303 forks source link

Update jquery.socialfeed.js #146

Closed HartLarsson closed 8 years ago

HartLarsson commented 8 years ago

I've added for "RSS feed type" the first image search instead of no image in case of mediaGroups empty (some blogs not provide that parameter in the feed). I've cheked also that in wordpress the element.mediaGroups[0].contents[0].url provide the Gravatar logo and not the first media image. so i switched to element.mediaGroups[0].contents[1].url Probably i will release a better solution for mediaGroups in few days

pavelk2 commented 8 years ago

@HartLarsson please do not leave console.log() in code so the console stays clean.

HartLarsson commented 8 years ago

yes sorry i cleaned the code :) there is another problem now Pavel, seems Google Feed API was def. removed and deprecated.

Webarkitekt commented 8 years ago

this is linked to issue #147

pavelk2 commented 8 years ago

@Webarkitekt As I understood we have @HartLarsson creating a pull request to fix some bugs. He is improving his pull request here. Why do we close this issue upon the pull request? Will we be able to still merge the pull request?

Webarkitekt commented 8 years ago

Because all the rss part has been rewrited here https://github.com/pavelk2/social-feed/commit/54a9d4583ebec055138d39b25b325a3726bf0302