search

pavelk2 / social-feed

JavaScript plugin that shows a user feed from the most popular social networks
http://pavelk2.github.io/social-feed-example/
MIT License
962 stars 304 forks source link

Rebuild rendering system to address incorrect date sorting #171

Closed tmlangley closed 8 years ago

tmlangley commented 8 years ago

This commit addresses an issue where post dates were being evaluated per service rather than globally for all services. Instead of running a render function for each post, we now aggregate all of the data together, sort it once everything has been loaded, then render it. This is discussed in issue #169

MaluNoPeleke commented 8 years ago

So how can I use that fix with the original social-feed version? I saw that your version is also 8 steps behind it...

tmlangley commented 8 years ago

I think we actually decided against implementing this approach since it's fairly intrusive and it removes the ability for posts to display as they are loaded meaning that the load time can feel a lot longer.

tmlangley commented 8 years ago

@MaluNoPeleke - See this thread for a better solution https://github.com/pavelk2/social-feed/issues/161

MaluNoPeleke commented 8 years ago

Thanks @tandroid1 but as I mentioned there I cannot get it to work without errors or have I tried the wrong solution?

HartLarsson commented 8 years ago

i've made a new version with tadroid1 idea but fixed for callback firing. in my repositori called jquery.socialfeed-render.js. My version adopt all patches, if appear 8 steps behind is svery strange because manually i add to my version all patches and fix applied and tested. Keep in mind is my development and is not intended to be very connected with official version.

Anyway using your twitter account and my jquery.socialfeed-render.js all works great:

http://grabilla.com/06709-18e03124-f410-40a8-b101-42a3f9defbbe.png

MaluNoPeleke commented 8 years ago

I have updated the jquery.socialfeed-render.js from you but as you can see the container stays empty: http://peleke.diphda.uberspace.de/bower_components/social-feed/ If I use this version it works wihtout any other edits: https://github.com/HartLarsson/social-feed/blob/gh-pages/js/jquery.socialfeed.js

HartLarsson commented 8 years ago

if you use chrome .. use the debugger. You have some facebook error because you try to collect facebook feed from a fb profile not a facebook Page!

MaluNoPeleke commented 8 years ago

Now it works, I think the Facebook setting was the problem :)