Callback not working when amount of posts is less than the sum of the limits

pavelk2 / social-feed

JavaScript plugin that shows a user feed from the most popular social networks

http://pavelk2.github.io/social-feed-example/

MIT License

963 stars 304 forks source link

Callback not working when amount of posts is less than the sum of the limits #260

Open FerdyHoefakker opened 7 years ago

FerdyHoefakker commented 7 years ago

Example:


facebook:{
limit: 5
},
twitter:{
limit: 5
},
instagram:{
limit:5
}

The sum of the limits is now 15. If however my instagram only has 2 images, the loaded_post_count == posts_to_load_count check in the SocialFeedPost.render function will never be true. As a result fireCallback() is never triggered and nothing happens.

-Ferdy

HartLarsson commented 7 years ago

i've fixed it redesign the rendering part. You can check my forked version here https://github.com/HartLarsson/social-feed