Fix: Twitter timestamps were wrong when localized

pavelk2 / social-feed

JavaScript plugin that shows a user feed from the most popular social networks

http://pavelk2.github.io/social-feed-example/

MIT License

960 stars 303 forks source link

Fix: Twitter timestamps were wrong when localized #86

Closed robertsass closed 9 years ago

robertsass commented 9 years ago

While localization worked for Facebook, all Twitter posts were labeled to be 4 months old.

pavelk2 commented 9 years ago

Could you please comment here and leave some examples - how it worked with your fix and without - just to have an idea. Did you also validate how it works in Safari, Chrome and IE? Thank you!

robertsass commented 9 years ago

Twitter posts were translated into German like that: "5 days ago" => "vor 4 Monaten" (4 months ago) "9 days ago" => "vor 4 Monaten" "one day ago" => "vor 4 Monaten" Actually I tried in Safari and Chrome. But my guess is, that the API changed and does not need a specific date format definition anymore for conversion.

pavelk2 commented 9 years ago

Great, thank you very much for your contribution. Please give a look also here: https://github.com/moment/moment/issues/1407 (the message is show in the developers console when social-feed is used), it would be great if you can contribute also - fixing moment construct depreciation issue.