search

pavelk2 / social-feed

JavaScript plugin that shows a user feed from the most popular social networks
http://pavelk2.github.io/social-feed-example/
MIT License
960 stars 303 forks source link

Instagram and/or operator added #99

Closed Buochserhorn closed 9 years ago

Buochserhorn commented 9 years ago

for the setup of instagram in index.html the following line can be added:

operator: 'AND', //either write AND or OR for the posts to fulfil either account OR hashtag or to fulfil account AND hashtag

and the script either chooses posts with the named account and hashtag or when operator = OR it just does what it did before.

For questions concerning the changes, just ask.

Best Buochserhorn

pavelk2 commented 9 years ago

Dear @Buochserhorn, I believe that your solution has some relation to https://github.com/pavelk2/social-feed/issues/98.

Idea

There might be a problem of receiving less posts as requested with limit attribute. What is the point of using such approach rather than just checking the presence of a hashtag or an author in a moderation function https://github.com/pavelk2/social-feed/blob/gh-pages/index.html#L109-L111.

Implementation

Even if we agree that the idea is good - i still can not accept this pull request as it is designed for Instagram only

Buochserhorn commented 9 years ago

Dear @pavel2k

Thanks for your response!

Yeah I saw #98 right after I did the pull request. :-)

The Problem with receiving less posts is somehow fixed, as, if the operator is set to 'and', the limit that is inserted into the url is set to 60.

The moderation function: As the setup had 'fuck' as default, I thought that it was intended for censoring/moderation and didn't get the idea, that it could be changed to use the other way round. I tried it, it worked, but as you stated I receive less posts.

And true, implementation for instagram only isn't great, but as I need facebook and instagram only, it was enough for me. I'm fine with not accepting the pull request. We'll see, maybe I'll once have time and knowledge enough to expand it for all networks. Because the chosen solution for not receiving enough posts is not to my full satisfaction yet and how to solve it in another way exceeds my competences right now..

Best Buochserhorn