search

pavelkomarov / exportify

Export Spotify playlists using the Web API. Analyze them in the Jupyter notebook.
https://exportify.net
MIT License
210 stars 24 forks source link

Display playlist images instead of ♫ icons #49

Closed pavelkomarov closed 2 months ago

pavelkomarov commented 2 months ago

It is possible to fetch playlist images. It wouldn't be that hard to grab them around the same time the code is grabbing the list of playlists and display them in the table.

ChinoUkaegbu commented 2 months ago

Also unrelated but in the exportify.js comments I see that you pointed out // createElement is a legacy API but it's unclear what the recommendation is to modernize. I believe using JSX would be the alternative (would be a lot more readable as well imo)

pavelkomarov commented 2 months ago

Whoa! A wild contributor has appeared! I'll take a look at the PR. Thank you.

And yes, I think JSX is the way. I've got #48 for this.

pavelkomarov commented 2 months ago

Wow. It works spectacularly, and it's like a two-line change. It turns out those images come as part of the playlist data, so I was already fetching them. Didn't realize. Good work!

ChinoUkaegbu commented 2 months ago

Whoa! A wild contributor has appeared! I'll take a look at the PR. Thank you.

And yes, I think JSX is the way. I've got #48 for this.

will check that out!