paveloom-f / lbry-android

The LBRY Android app (now without a blacklist)
https://lbry.com
MIT License
12 stars 0 forks source link

No Apks on the Releases page #3

Closed paju1986 closed 2 years ago

paju1986 commented 2 years ago

There is no apks available for download

nukelr commented 2 years ago

Indeed...

paveloom commented 2 years ago

Oh, it seems like I wasn't getting notifications from this repository. Sorry for the delay.

I suppose there was an automatic build that somehow bypassed the latest release check and tried to recreate the release. Since the code base of the original repository is full of deprecated methods, the build failed, but a release was created anyway, without an artifact.

I'm looking for a solution on the test-build branch, but I am quite busy at the moment, so this will have to wait for a couple of days.

nukelr commented 2 years ago

I should thank you instead :-) ...this motivated me to try building the app myself and I succeeded! I would ask if you know how to disable the autoupdate feature of lbry-desktop in the code. Any suggestion would be very appreciated and thank you so much for the good job you did!! Anyway I've used your patches on the lbry-fdroid sources to get rid of Goolag Firebase s**t too ;) You could consider to do that too for your releases ;)

paveloom commented 2 years ago

Aight, downgrading NDK to r16b was enough. The APKs are back on the Releases page.

@nukelr, concerning the auto-update feature of lbry-desktop, I just looked at the code, and I think you should find where this doCheckUpgradeSubscribe method is used and disable it.

doCheckUpgradeSubscribe

Concerning the F-Droid version, I didn't even know about that repository. Will look into it.

nukelr commented 2 years ago

Thanks I will look for that. Anyway regarding lbry-fdroid if you look into the gradle.build you will see that the 64bit variant is disabled ...I tried with uncommenting the lines and I got a working 64bit release. I don't know why they did that.

paveloom commented 2 years ago

Yep, see the change and the reasoning.