search

pavelsabatka / gtm-sklik

GTM template for sklik
Apache License 2.0
2 stars 0 forks source link

Template review feedback #1

Closed praveena-pappu closed 3 years ago

praveena-pappu commented 4 years ago

Thanks for submitting a template to the gallery, there were a few issues in your template that needed to be resolved ahead of approving the template for the gallery.

1) encodeUriComponent should be used on user provided values that are then used as parameters in your url. These methods take in a single text argument and return a URI Encoded string. You should use this method on "data.id" parameter while generating the URL let url = "https://c.imedia.cz/conv?id=' + data.id"

pavelsabatka commented 4 years ago

Updated ᐧ

On Tue, May 19, 2020 at 9:10 PM praveena-pappu notifications@github.com wrote:

Thanks for submitting a template to the gallery, there were a few issues in your template that needed to be resolved ahead of approving the template for the gallery.

  1. encodeUriComponent should be used on user provided values that are then used as parameters in your url. These methods take in a single text argument and return a URI Encoded string. You should use this method on " data.id" parameter while generating the URL let url = " https://c.imedia.cz/conv?id=' + data.id"

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pavelsabatka/gtm-sklik/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANWCYHYUHSN7F3M2TWLBJLRSLKUFANCNFSM4NFIYFLA .

-- Pavel Šabatka Web Analytik Tel: +420 776 236 855 Skype: sabatkapavel

pavelsabatka commented 4 years ago

Hi, I updated generating of URL - all parameters are encoded. Can I help somehow with approving a template? Pavel ᐧ

On Tue, May 19, 2020 at 9:10 PM praveena-pappu notifications@github.com wrote:

Thanks for submitting a template to the gallery, there were a few issues in your template that needed to be resolved ahead of approving the template for the gallery.

  1. encodeUriComponent should be used on user provided values that are then used as parameters in your url. These methods take in a single text argument and return a URI Encoded string. You should use this method on " data.id" parameter while generating the URL let url = " https://c.imedia.cz/conv?id=' + data.id"

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pavelsabatka/gtm-sklik/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANWCYHYUHSN7F3M2TWLBJLRSLKUFANCNFSM4NFIYFLA .

-- Pavel Šabatka Web Analytik Tel: +420 776 236 855 Skype: sabatkapavel