COMPATIBILITY: Modernize the component

paviliondev / discourse-discord-widget

Display a discord widget on your Discourse forum

GNU General Public License v2.0

0 stars 2 forks source link

COMPATIBILITY: Modernize the component #2

Closed Arkshine closed 2 months ago

Arkshine commented 2 months ago

This PR modernizes the components:

Use the new header API
Convert widget to glimmer components
Move settings description to locale file
Add acceptance tests
Add CI workflow config file

Other changes made:

theme setting is now defaulted to auto.
Add a loading spinner until the iframe is loaded.
Color scheme detection relies on the Discourse CSS --scheme-type variable instead of the system.

https://github.com/user-attachments/assets/a24cacaf-7bf1-4874-84e2-592ecfb32126

angusmcleod commented 2 months ago

@Arkshine Amazing! Thank you.

angusmcleod commented 2 months ago

The workflow isn't being picked up. Is the path right?

Arkshine commented 2 months ago

The workflow isn't being picked up. Is the path right?

~~You're right, the path was wrong, but it doesn't seem to have an effect. Is it required to be named "component-linting.yml"?~~ That doesn't seem to be the case. Not sure why now. Is it configured on this repository?

angusmcleod commented 2 months ago

@Arkshine Thanks again.