pavkam / tzdb

Delphi/FPC Time Zone Database
https://www.iana.org/time-zones
BSD 3-Clause "New" or "Revised" License
84 stars 27 forks source link

Update to version 2020f #36

Closed zedxxx closed 3 years ago

zedxxx commented 3 years ago

I want update library to version 2020f, but when I run script it fails with error:

  TTZDBTest Time:00.058 N:38 E:0 F:1 I:0
    00.003  Test_Africa_Accra_1997  Failed: "DST name differs for 0 period." expected: <GMT> but was: <>
      Exception:   "DST name differs for 0 period." expected: <GMT> but was: <>
      at   $0000000000433E5A
  TTZDB_St_Johns_2018_Test Time:00.002 N:13 E:0 F:0 I:0
  TTZDB_London_2018_Test Time:00.002 N:13 E:0 F:0 I:0
  TTZDB_Canberra_2018_Test Time:00.003 N:13 E:0 F:0 I:0
  TTZDB_NewYork_2018_Test Time:00.002 N:13 E:0 F:0 I:0

Number of run tests: 90
Number of errors:    0
Number of failures:  1

List of failures:
  Failure: 
    Message:           TTZDBTest.Test_Africa_Accra_1997: "DST name differs for 0 period." expected: <GMT> but was: <>
    Exception class:   EAssertionFailedError
        at   $0000000000433E5A

[ERR] Tests failed! Please correct the errors before continuing.

There are also a few errors with aliases (are they critical?):

ERROR: Alias "Africa/Asmera" already points to zone "Africa/Asmara". Cannot reassign to zone "Africa/Nairobi".
ERROR: Alias "Antarctica/South_Pole" already points to zone "Antarctica/McMurdo". Cannot reassign to zone "Pacific/Auckland". 
ERROR: Alias "Asia/Chungking" already points to zone "Asia/Chongqing". Cannot reassign to zone "Asia/Shanghai".
ERROR: Alias "UTC" already points to zone "Etc/UTC". Cannot reassign to zone "Etc/GMT".

and script can't find two files during update (it seems, they was removed as obsolete):

cp: cannot stat './iana_temp/pacificnew': No such file or directory
cp: cannot stat './iana_temp/systemv': No such file or directory
pavkam commented 3 years ago

@zedxxx, thanks for the reports and sorry for late reply.

I have updated to 2021a and fixed the test. It was failing due Accra rule changes in IANA TZDB. I've also removed those old files you mentioned.

The Alias errors are expected and not a problem.

Closing as fixed.

zedxxx commented 3 years ago

Thanks.