Cannot compile TZDB.pas in Android and iOS platform due to usage of unit contnrs

pavkam / tzdb

Delphi/FPC Time Zone Database

https://www.iana.org/time-zones

BSD 3-Clause "New" or "Revised" License

84 stars 27 forks source link

Cannot compile TZDB.pas in Android and iOS platform due to usage of unit contnrs #5

Closed ccy closed 6 years ago

ccy commented 6 years ago

tzdb cannot compile in Android and iOS platform due to the usage of unit contnrs. I think TBucketList may be replaced by TDictionary.

pavkam commented 6 years ago

Thanks for your bug report. @mbtaylor1982 you mind giving it a look? I've got not Delphi license.

pavkam commented 6 years ago

@ccy, As far as I remember, the TBitBucket was used due to it being shared across Delphi and FPC. TDictionary was not compatible at the time. I am not sure now what is going on,

ccy commented 6 years ago

Your code base was designed to work for both Delphi and FPC. FPC might not have TDictionary.

mbtaylor1982 commented 6 years ago

I’m busy moving house and with work commitments right now but as soon as I’m free I’ll take a look.

ccy commented 6 years ago

I have done the fix: https://github.com/pavkam/tzdb/pull/6

pavkam commented 6 years ago

Thanks @mbtaylor1982, no worries about it. @ccy, I'll give it a look.

pavkam commented 6 years ago

Merged the PR