Closed dkobak closed 4 years ago
First, there is some warning from sklearn.
This is likely due to the call to repr
, and should be fixed on their end.
Second, "Finding 90 nearest neighbors using auto search" sounds a little unhelpful; it would be better it said "Finding 90 nearest neighbors using annoy search".
I agree, but it makes the code a little messier. But it's probably worth it.
Third, there is a typo in "Calcualting affinity matrix". ... Also, you might a separate ===> entry for initialization. At least with spectral it can take some time, but I guess pca on a large dataset can also take some non-negligible time.
I actually wanted to include exactly this in the spectral commit for both PCA and spectral init methods but forgot to push the commit. By the time I noticed, I had already merged to master, so it was too late.
Will fix 2. and 3. tomorrow.
===> Running optimization with exaggeration=1, lr=1666.6666666666667 for 500 iterations...
You might want to print the learning rate as {:.1f}
or something.
Yes, good idea.
Another thing: verbose=1 prints neighbors=None
(see above) instead of the actual value of neighbors
.
I've just tried running openTSNE with verbose=1 and got this output:
I think it looks great overall, but several small things caught my attention: first, there is some warning from sklearn. Second, "Finding 90 nearest neighbors using auto search" sounds a little unhelpful; it would be better it it said "Finding 90 nearest neighbors using annoy search". For this, the verbose=1 should probably be passed into
build_knn_index()
and it should print the message after the method is resolved. Third, there is a typo in "Calcualting affinity matrix".Also, you might a separate
===>
entry for initialization. At least withspectral
it can take some time, but I guesspca
on a large dataset can also take some non-negligible time.