search

pavlov99 / json-rpc

🔁 JSON-RPC 1/2 transport implementation. Supports python 2/3 and pypy.
http://json-rpc.readthedocs.org
MIT License
464 stars 101 forks source link

REF: function parameter introspection #104

Closed pavlov99 closed 5 years ago

pavlov99 commented 5 years ago

Description of the Change

Alternate Designs

Use a mix of getargspec and getfullargspec and try to keep py2 and py3 code similar.

Benefits

Use modern methods in modern python Have better control over function parameter introspection via lower level methods

Possible Drawbacks

N/A

Applicable Issues

N/A

codecov[bot] commented 5 years ago

Codecov Report

Merging #104 into master will decrease coverage by 1.17%. The diff coverage is 68.18%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #104      +/-   ##
=========================================
- Coverage   80.48%   79.3%   -1.18%     
=========================================
  Files          10      10              
  Lines         538     546       +8     
=========================================
  Hits          433     433              
- Misses        105     113       +8
Impacted Files Coverage Δ
jsonrpc/utils.py 82.97% <68.18%> (-17.03%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3bad461...906bd95. Read the comment docs.