Docs: Update Hello World Demo & Fix: issues with sys.stdin/deepcopy

pawamoy / archan

Analysis of your architecture strength based on DSM data.

https://pawamoy.github.io/archan/

ISC License

12 stars 1 forks source link

Docs: Update Hello World Demo & Fix: issues with sys.stdin/deepcopy #45

Closed KyleKing closed 3 years ago

KyleKing commented 3 years ago

Fix: #44

KyleKing commented 3 years ago

I'm not sure what the Windows environment is missing, but seems at least to pass all non-Windows tests consistent with the main branch

Update: I thought rm wasn't available on the Windows test environment and tested using shutil.rmtree / Path.unlink for cross-platform support, but that doesn't appear to be the issue. The Windows tests are still failing? It isn't clear what command subprocess is attempting to run. I walked back the changes tried for Windows to keep the PR clean

pawamoy commented 3 years ago

Thanks a lot!

Don't worry too much about Windows right now. If I remember correctly, invoke doesn't work properly in GitHub Workflow's Windows containers. I wrote duty to fix this, among other things. Lets merge this, and I'll update the project with my latest template changes to see how CI behaves with duty.

pawamoy commented 3 years ago

Also if you send more PRs :heart: , please use a capital letter at the beginning of the commit subject (or even Markdown syntax):

docs: Minor updates to README-CLI
fix: sys.stdin issue and deepcopy()
build: Make dependenpy optional

KyleKing commented 3 years ago

Oh I see, that makes sense that Invoke is causing the Windows failures

Okay! Of course my next commit started with a variable name 😄

I think this is ready to merge now!