search

pawamoy / aria2p

Command-line tool and library to interact with an aria2c daemon process with JSON-RPC.
https://pawamoy.github.io/aria2p
ISC License
475 stars 93 forks source link

Feature Request: Customisable Path #131

Open cloudwindy opened 8 months ago

cloudwindy commented 8 months ago

Is your feature request related to a problem? Please describe. I'm using an unusual setup to avoid botnet scans. But it seems the path is fixed at /jsonrpc. https://github.com/pawamoy/aria2p/blob/0713e4d2de6d88a7758def1ed7780d9cbb1f74f6/src/aria2p/client.py#L219

Describe the solution you'd like Removing /jsonrpc would not be a great idea because it changes user behavoir and breaks scripts. So we can instead make an option to disable this behavior.

Describe alternatives you've considered I'm not aware of any alternatives.

Additional context Installed with pipx.

pawamoy commented 7 months ago

Hi, thanks for the request.

Do you mean aria2c's server is served without the trailing /jsonrpc part? Isn't that hardcoded by aria2c itself? Could you share how you launch aria2c's daemon server, censoring sensitive information? For example, do you use the --interface option or something else?

cloudwindy commented 7 months ago

Hello, I'm running a caddy https reverse proxy in front of aria2c. I don't find it a good idea to expose 6800 http port so everything is going through the proxy.

pawamoy commented 7 months ago

Ha, yes, a reverse proxy, of course, didn't think of that :) thanks! Then this feature request is accepted! Pull requests are welcome, otherwise I'll eventually get to it :)