search

pawanwiziq / moodlenew-mod_wiziq

moodle latest
0 stars 0 forks source link

consider adding support for travis ci #8

Open danmarsden opened 6 years ago

danmarsden commented 6 years ago

The checks run in the moodle.org plugins db can also be run automatically here on github using the travis-ci integration. You can see the list of current failures reported here: (you may need to be logged in to view this page) https://moodle.org/plugins/pluginversion.php?id=17672&smurf=html#phpcs

More information on this is here: https://moodle.org/mod/forum/discuss.php?d=323384 Adding Travis support and fixing the reported issues will also address a number of things we would notice during a full review.

Integrating with travis is optional and will not block approval in the plugins db, but it does make the review process a bit easier and usually provides a good way to ensure future compliance with coding guidelines etc.

The link I give above gives the full details, but here's a short step-by-step to show you how easy it is to add.

grab this file: https://github.com/moodlerooms/moodle-plugin-ci/blob/master/.travis.dist.yml rename it as .travis.yml and put in the root of your github directory. Go to: https://travis-ci.org/profile/pawanwiziq Flick the switch on the moodlenew-mod_wiziq

then on every commit you make to github it will fire off a request to travis to run the tests in .travis.yml and will give you traffic lights beside each commit and generate a report.

something else you might want to change: in .travis.yml the default file has this line:

env: global:

MOODLE_BRANCH=MOODLE_32_STABLE you might want to add other branches to that list (or remove 32_STABLE because it's not supported.) so you might want to change it something like:

env: global:

MOODLE_BRANCH=MOODLE_34_STABLE MOODLE_BRANCH=MOODLE_35_STABLE

pawanwiziq commented 6 years ago

We will surely add this in future version.

danmarsden commented 6 years ago

The plugin review team is quite busy, adding travis ci support (and fixing the reported issues) will make it much easier for us to review your code. You do not have to do this, but it's very easy to do, and better compliance with the overall coding guidelines may decrease the time it takes for your plugin to get through the review queue.

I'm also not sure why you have assigned a number of these issues to me.. the few that I have checked so far haven't actually been completed.