search

pawelad / pymonzo

Modern Python API client for Monzo public API.
https://pymonzo.pawelad.dev/
Mozilla Public License 2.0
21 stars 21 forks source link

Add counterparty support #35

Closed csogilvie closed 5 months ago

csogilvie commented 5 months ago

Also fixes #34

csogilvie commented 5 months ago

I note that the tests are failing in some cases, but my local version was doing this before the code changes I made too.

pawelad commented 5 months ago

Thank you for taking the time to do this! Next time, would you mind separating the bug fix from the new feature (as in, one PR per bug / feature / thing)?

Don't worry about the failing tests CI - unfortunately I wasn't able to get it to work on PRs and decided to leave it for now, as I think I want to get rid of VCR usage anyway, it's too fragile with how undocumented the Monzo API is.

csogilvie commented 5 months ago

Thank you for taking the time to do this! Next time, would you mind separating the bug fix from the new feature (as in, one PR per bug / feature / thing)?

Can do; sorry - was just the way I've been itteratively fixing things locally to get things to work!

pawelad commented 5 months ago

Also, do you mind sharing the raw JSON for an example transaction with the counterparty set? I don't see it in their docs nor in any of my transactions. Thanks!

csogilvie commented 5 months ago

Also, do you mind sharing the raw JSON for an example transaction with the counterparty set? I don't see it in their docs nor in any of my transactions. Thanks!

{ account_id: acc_id, amount: amt, amount_is_pending: false, atm_fees_detailed: null, attachments: null, can_add_to_tab: false, can_be_excluded_from_breakdown: false, can_be_made_subscription: false, can_match_transactions_in_categorization: false, can_split_the_bill: false, categories: { income: amt }, category: "income", counterparty: { account_number: "12345678", name: "name", sort_code: "123456", user_id: "anonuser_string" }, created: "2024-04-21T05:30:14.08Z", currency: "GBP", dedupe_id: "ID", description: "DESC", fees: { }, id: "tx_string", include_in_spending: false, international: null, is_load: false, labels: null, local_amount: amt, local_currency: "GBP", merchant: null, merchant_feedback_uri: "URL", metadata: { faster_payment: "true", fps_fpid: "fp_id", fps_payment_id: "payment_id", insertion: "id", ledger_committed_timestamp_earliest: "2024-04-21T05:30:14.336Z", ledger_committed_timestamp_latest: "2024-04-21T05:30:14.336Z", notes: "notes", standin_correlation_id: "id", trn: "id" }, notes: "notes", originator: false, parent_account_id: "", scheme: "payport_faster_payments", settled: "2024-04-22T06:00:00Z", updated: "2024-04-21T05:30:14.801Z", user_id: "" }