search

pawelgabryelewicz / babel-preset-typescript-vue

TypeScript preset for Babel 7.x supporting Vue.js components written in TS
MIT License
22 stars 4 forks source link

Version 1.0.3 on npm is still using code generated from previous version #4

Closed lephuongbg closed 4 years ago

lephuongbg commented 4 years ago

File lib/index.js at line 32 still contains the old code:

if (typeof json.script !== "undefined" && typeof json.script["@_lang"] && json.script["@_lang"].toLowerCase() === "ts") {
  return true;
}

while it should be the same with index.js:

if(json.script && typeof json.script === "object" && typeof json.script["@_lang"] === "string" && json.script["@_lang"].toLowerCase() === "ts") {
 return true;
}

Please issue a new version with the new code. Thanks for this nice plugin.

Merott commented 4 years ago

Just spent 2 hours trying to debug an issue, only to find the same issue as @lephuongbg shared here. 😞

Can we please get a new release to fix this?

bbugh commented 4 years ago

I documented reproduction steps on the pull request that caused this, in case it matters: https://github.com/pawelgabryelewicz/babel-preset-typescript-vue/pull/1#issuecomment-624412257

pawelgabryelewicz commented 4 years ago

Please update to 1.0.4, should be fixed.