search

pawelgrzybek / gatito-theme

Minimalistic and modern looking fork of fantastic Oceanic theme for Visual Studio Code.
https://marketplace.visualstudio.com/items?itemName=pawelgrzybek.gatito-theme
80 stars 9 forks source link

Theme does not load anymore #5

Closed cideM closed 6 years ago

cideM commented 6 years ago

I think that you might have accidentally introduced a trailing comma in https://github.com/pawelgrzybek/gatito-theme/commit/51e9fd4dce5ba46c91d31db188e009a35098aa8d specifically https://github.com/pawelgrzybek/gatito-theme/blob/master/themes/gatito-theme-color-theme.json#L330

Without that, the theme loads without problems, with it I get Unable to load file:///Users/yuuki/.vscode-insiders/extensions/pawelgrzybek.gatito-theme-0.2.1/themes/gatito-theme-color-theme.json: Problems parsing JSON theme file: Property name expected, Value expected

I'm using the latest insiders on the latest MacOS

pawelgrzybek commented 6 years ago

Hi.

It is working for me with no issues just like expected on stable version.

I just removed and re-downloaded it — works like a charm.

cideM commented 6 years ago

Then this appears to be an insiders issue. It happens with a lot of themes actually.

pawelgrzybek commented 6 years ago

Ufff 😌

It is worth to raise a bug on VSCode repo in this case.

Thanks a lot and have a good day ‼️