search

pawelgrzybek / snippet-generator

Snippet generator for Visual Studio Code, Sublime Text and Atom
https://snippet-generator.app/
1.74k stars 202 forks source link

Placeholder #16

Closed alexneo2003 closed 5 years ago

alexneo2003 commented 5 years ago

https://snippet-generator-jbculetreh.now.sh/

pawelgrzybek commented 5 years ago

Hi.

I like the functionality of reusing selected text as a label for placeholder. I am not convinced about numerating placeholders though. My reasoning:

  1. Not many people create advanced snippets using placeholders.
  2. It unnecessarily adds it to the state and URL param.

I will review this PR soon and cherry pick my favourite bits and merge it.

Thanks for your contribution.