Fix `\` and `$` escape error in VSCode snippet

pawelgrzybek / snippet-generator

Snippet generator for Visual Studio Code, Sublime Text and Atom

https://snippet-generator.app/

1.74k stars 202 forks source link

Fix `\` and `$` escape error in VSCode snippet #22

Closed sabertazimi closed 5 years ago

sabertazimi commented 5 years ago

Examples

VSCode JSON snippet => true output

"\\" => "\"
"\\\\" => "\"
"\\begin" => "\begin"
"\$" => "$"
"\$abc" => "$abc"
"\\\$" => "\$"
"\\\$abc" => "\$abc"
"\\\\\$" => "\$"
"\\\\\$abc" => "\$abc"

pawelgrzybek commented 5 years ago

Hi.

I finally had a chance to review your PR. You did an amazing job and I am really thankful for your time, effort and research. It fixes the issue #13 but unfortunately introduces a new issue. Because you target all $ it escapes placeholders too. The syntax for placeholder is $1, $2, $3 or ${1:name}, ${2:surname}, ${1:age}. It breaks this feature.

I am closing this one for now and feel free to resubmit if you have a fixed implementation.

Thanks a lot and have a nice weekend.