Open disaac opened 2 years ago
Thank you for this contribution. Let me run your implementation against few different test cases manually and I will merge it. most likely after the weekend. Thank you again!
Thank you for this contribution. Let me run your implementation against few different test cases manually and I will merge it. most likely after the weekend. Thank you again!
@pawelgrzybek I actually found some bashisms that will still fail to be properly converted. I don't have time at the moment to PR on this but wanted to mention it since my PR would only address the cases mentioned in the issue:
echo "${someArray[@]}"
echo "${someArray[*]}"
settingDefaultValue="${settingDefaultValue:-"DefaultValue"}"
The above examples wouldn't be properly handled by the \w+
and would need to be addressed by another replace.
${variable}
and$variable
${1:placeholder}
are still properly handled. The replace is only looking for word characters after${
and before}
so shouldn't replace when:
is present.Issue: #68