pawelrojek / nextcloud-drawio

Draw.io intergration app
https://apps.nextcloud.com/apps/drawio
GNU Affero General Public License v3.0
227 stars 60 forks source link

Nextcloud 21/PHP 8.0 still not working #137

Closed JoshuaPettus closed 3 years ago

JoshuaPettus commented 3 years ago

Hi, I tried the new 0.9.9 version of the app and it still fails to load. When the app opens up I get a "Internal Server Error" page

I'm not sure if this is because I'm using NC21 or PHP8.0 at this point

This is the output from the log

{"reqId":"eXxNt0qVSiKYd66q81Nl","level":3,"time":"2021-03-04T19:58:05+00:00","remoteAddr":"*******","user":"******","app":"index","method":"GET","url":"/apps/drawio/651024","message":{"Exception":"ArgumentCountError","Message":"Too few arguments to function OCA\\Drawio\\Controller\\EditorController::__construct(), 8 passed in /var/www/nextcloud/apps/drawio/appinfo/application.php on line 93 and exactly 10 expected","Code":0,"Trace":[{"file":"/var/www/nextcloud/apps/drawio/appinfo/application.php","line":93,"function":"__construct","class":"OCA\\Drawio\\Controller\\EditorController","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":155,"function":"OCA\\Drawio\\AppInfo\\{closure}","class":"OCA\\Drawio\\AppInfo\\Application","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/nextcloud/3rdparty/pimple/pimple/src/Pimple/Container.php","line":118,"function":"OC\\AppFramework\\Utility\\{closure}","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php","line":122,"function":"offsetGet","class":"Pimple\\Container","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":453,"function":"query","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":431,"function":"queryNoFallback","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/App.php","line":130,"function":"query","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->"},{"file":"/var/www/nextcloud/lib/private/Route/Router.php","line":302,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"/var/www/nextcloud/lib/base.php","line":993,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"/var/www/nextcloud/index.php","line":37,"function":"handleRequest","class":"OC","type":"::"}],"File":"/var/www/nextcloud/apps/drawio/controller/editorcontroller.php","Line":75,"CustomMessage":"--"},"userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.182 Safari/537.36 Edg/88.0.705.81","version":"21.0.0.18","id":"60413c3563244"}

pawelrojek commented 3 years ago

I finally tested it on PHP 8.0.3 and I have no problems...

Also this is really weird: "Too few arguments to function OCA\Drawio\Controller\EditorController::__construct(), 8 passed in /var/www/nextcloud/apps/drawio/appinfo/application.php on line 93 and exactly 10 expected"

Line 93:

          return new EditorController(
                $c->query("AppName"), //1
                $c->query("Request"), //2
                $c->query("RootStorage"), //3
                $c->query("UserSession"), //4
                $c->query("ServerContainer")->getURLGenerator(), //5
                $c->query("L10N"), //6
                $c->query("Logger"), //7
                $this->appConfig, //8
                $c->query("IManager"), //9
                $c->query("Session") //10
            );

That's 10 parameters as expected.

JoshuaPettus commented 3 years ago

Weird...

JoshuaPettus commented 3 years ago

I haven't been getting this error anymore in my log. Indeed the app is now loading just fine. I think what you did for #138 also fixed this

Thank you!