Use HTML numbering for quotes

[fuzzyhandle]

Literal " and ' characters need escaping. Use HTML numbers to bypass escaping

[pawelrychlik]

@fuzzyhandle I did some testing here and these are my findings:

(line ~91)

summary = 'double" and single' + "' hello !@#$%^&*()-_+=123[];,./23" # hardcode some special chars
summary = summary.replace('"', '\\"') # version 1
summary = summary.replace('"', '"').replace("'", "'") # version 2

And it appears to me that version 2 produces a corrupt output chart image. While the original version 1 handles it nicely. Also, my results seem to be consistent across python 2.7 and 3.

Could you please double check it on your end?

[fuzzyhandle]

interesting.

I will send you a usecase where the older logic fails when rendering the DOT file and replacing it with hex sequence fixes the problem.

On Fri, Feb 7, 2020 at 5:26 PM Paweł Rychlik notifications@github.com wrote:

@fuzzyhandle https://github.com/fuzzyhandle I did some testing here and these are my findings:

(line ~91)

summary = 'double" and single' + "' hello !@#$%^&*()-_+=123[];,./23" # hardcode some special chars summary = summary.replace('"', '\"') # version 1 summary = summary.replace('"', '"').replace("'", "'") # version 2

And it appears to me that version 2 produces a corrupt output chart image. While the original version 1 handles it nicely. Also, my results seem to be consistent across python 2.7 and 3.

Could you please double check it on your end?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pawelrychlik/jira-dependency-graph/pull/38?email_source=notifications&email_token=ACK6UO4U5AU52F3F7ITAFWTRBVD6BA5CNFSM4KRB6YU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELCV4FA#issuecomment-583360020, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACK6UOZDLEJR2GFU4RMLEMTRBVD6BANCNFSM4KRB6YUQ .