search

pawelsalawa / sqlitestudio

A free, open source, multi-platform SQLite database manager.
https://sqlitestudio.pl
Other
4.64k stars 571 forks source link

3.3.3: Builds during 'install' target #4062

Open yurivict opened 3 years ago

yurivict commented 3 years ago

Details

It keeps building in the 'install' target: https://people.freebsd.org/~yuri/sqlitestudio-3.3.3.log (after the Staging for sqlitestudio-3.3.3 message)

Not sure if this is a regression, but this behavior is certainly wrong.

OS: FreeBSD 12.2

pawelsalawa commented 3 years ago

I'm not sure what the problem is. Could you put it in different words?

yurivict commented 3 years ago

The install target doesn't install SQLiteStudio, instead it compiles C++ files.

pawelsalawa commented 3 years ago

This is weird. There were no changes to makefiles/project files, except for the yml files used by GitHub actions only and for MacOS bundle builder script. Linux/Unix build was not touched.

I don't know why it behaves this way under FreeBSD. In any case, you can review all changes between 3.3.2 and 3.3.3 under this link https://github.com/pawelsalawa/sqlitestudio/compare/3.3.2...3.3.3 (there is a tab "Files changed" - very helpful).

yurivict commented 3 years ago

Bug in the cmake project: https://gitlab.kitware.com/cmake/cmake/-/issues/22094