Uncommited structure modification when tab change

[marcpley]

Details

This don't work when clicking on "Go back to structure tab" : if "Place data tab as first place" is set in config:

Steps to reproduce

Modify table structure and try to go to data tab before commit the structure modification.

[marcpley]

Bug-fix proposal : In ../guiSQLiteStudio/windows/tablewindow.cpp line 1345 ui->tabWidget->setCurrentIndex(0); add that before

            if (CFG_UI.General.DataTabAsFirstInTables.get())
                ui->tabWidget->setCurrentIndex(1);
            else

In ../guiSQLiteStudio/windows/viewwindow.cpp line 622 ui->tabWidget->setCurrentIndex(0); add that before

                if (CFG_UI.General.DataTabAsFirstInViews.get())
                    ui->tabWidget->setCurrentIndex(1);
                else

[pawelsalawa]

Thank you! Just applied.

P.S. You can always attach diff files (git diff) to posts - it will be easier/quicker for you.

[marcpley]

Bug-fix proposal : In ../guiSQLiteStudio/windows/tablewindow.cpp line 1345

            if (res == 1)
            {
                commitStructure(true);
                ui->tabWidget->setCurrentIndex(CFG_UI.General.DataTabAsFirstInTables.get() ? 0 : 1);
                ui->dataView->refreshData();
            }
            else
                ui->tabWidget->setCurrentIndex(CFG_UI.General.DataTabAsFirstInTables.get() ? 1 : 0);

[pawelsalawa]

Okay, this time I hope it's fully fixed ;) Please git pulll and check on your side.