search

pawelsikora / mkdocs-with-confluence

MkDocs plugin for uploading markdown documentation to Confluence via Confluence REST API
MIT License
67 stars 33 forks source link

Upload attachements on post page to support other mkdocs plugins #15

Closed ssaraswati closed 1 year ago

ssaraswati commented 1 year ago

Upload images from the on post page event instead of on markdown so that they can be accessed from the site directory instead of source directory.

This allows images generated from other plugins (e.g. https://github.com/AVATEAM-IT-SYSTEMHAUS/mkdocs-kroki-plugin) to be uploaded to confluence as attachments.

Additionally update the regex to not match file descriptions as part of the file name by excluding spaces and commas from the group.

simonstamm commented 1 year ago

Hi @ssaraswati,

is there a reason you removed the - from the regex? (r"!\[[\w\. -]*\] to r"!\[[\w\. ]*\])

ssaraswati commented 1 year ago

Hi @ssaraswati,

is there a reason you removed the - from the regex? (r"!\[[\w\. -]*\] to r"!\[[\w\. ]*\])

Was missed when updating from main, have restored it now

pawelsikora commented 1 year ago

Hi @ssaraswati,

is there a reason you removed the - from the regex? (r"!\[[\w\. -]*\] to r"!\[[\w\. ]*\])

@simonstamm Thanks for spotting that and keeping an eye (had noticed this line as well when reading it on my phone, but I am pretty busy and slow in responses recently tbh... sry. Hope it will change sooner than later ;) )

@ssaraswati Nice, I like it - I will take a look at it during the incoming weekend and will merge it. Just note: 'attachments' instead of 'attachements' in a commit message. I will take a look if I would not like to break that changes into two (move upload to post / regex) and will get back to you when merging into main/releasing during the weekend.

ssaraswati commented 1 year ago

@ssaraswati Nice, I like it - I will take a look at it during the incoming weekend and will merge it. Just note: 'attachments' instead of 'attachements' in a commit message. I will take a look if I would not like to break that changes into two (move upload to post / regex) and will get back to you when merging into main/releasing during the weekend.

Have updated to fix the spelling issues on commit msg, happy to split up the two changes if you would like