search

pawitp / protobuf-decoder

JavaScript-based web UI to decode ad-hoc Protobuf data
https://protobuf-decoder.netlify.app/
MIT License
392 stars 91 forks source link

Fix empty string being parsed as empty embedded proto #11

Closed pawitp closed 5 years ago

pawitp commented 5 years ago

An empty string is a valid protobuf message, but it's probably not intended as one.

This normally should not happen since empty strings are not encoded at all. However, BloomRPC encodes and includes it in the message.

Example: 52 00

codecov[bot] commented 5 years ago

Codecov Report

Merging #11 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   62.94%   62.94%           
=======================================
  Files           7        7           
  Lines         170      170           
  Branches       32       32           
=======================================
  Hits          107      107           
  Misses         59       59           
  Partials        4        4
Impacted Files Coverage Δ
src/ProtobufPart.js 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a87fc7e...1a518df. Read the comment docs.