search

pawitp / protobuf-decoder

JavaScript-based web UI to decode ad-hoc Protobuf data
https://protobuf-decoder.netlify.app/
MIT License
392 stars 91 forks source link

add upload file feature #86

Closed konsumer closed 5 months ago

konsumer commented 5 months ago

This resolves #85

It adds an upload button, that will take the contents of a file and inject it into the textarea.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 66.96%. Comparing base (46ef0b1) to head (800656f).

Files Patch % Lines
src/App.js 16.66% 3 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #86 +/- ## ========================================== - Coverage 69.73% 66.96% -2.78% ========================================== Files 9 9 Lines 228 224 -4 Branches 47 46 -1 ========================================== - Hits 159 150 -9 - Misses 64 67 +3 - Partials 5 7 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

konsumer commented 5 months ago

Not really sure what the codecoverage issues are about. I haven't changed really changed App.js, other than adding my button, but the tests are the same, and should be covered as much as they were before (it's not "less covered".)