HttpClient as an optional parameter

pawotter / mastodon-api-cs

The Mastodon API Client Library for C#

https://github.com/tootsuite/mastodon

MIT License

27 stars 4 forks source link

HttpClient as an optional parameter #23

Closed toryalsip closed 7 years ago

toryalsip commented 7 years ago

This change does the following:

Makes HttpClient optional for both MastodonApi and MastodonAuthClient classes
Calls into MastodonApi.GetDefaultHttpClient() if HttpClient is null
An additional unit test that check to assure MastodonApi.GetDefaultHttpClient() isn't returning null.

toryalsip commented 7 years ago

Not ready to have this merged yet. I will have some additional refinements to this soon, so I'm just looking for some initial feedback at this time.

toryalsip commented 7 years ago

@53ningen That makes more sense. I will have a chance to get that updated later tonight with that in mind. Thanks.

toryalsip commented 7 years ago

Updated and squashed down my commits to cleanup. 😀

toryalsip commented 7 years ago

Oh I didn't realize there were review comments before I squashed my commits down, so if you said something more than the IDisposable comments I missed it. Sorry about that. 😨