pawroman / zola-theme-terminimal

A simple, minimal retro theme for Zola
https://pawroman.github.io/zola-theme-terminimal/
Other
371 stars 85 forks source link

feat: Added a light version and an automatic (light/dark) version for… #45

Closed lynnpepin closed 1 year ago

lynnpepin commented 1 year ago

Thank you so much for your work here! I really love the Hugo Terminal theme, and I love the improvements you made, especially in removing the JavaScript.

This fork adds light themes, plus light and dark themes (which switch depending on user preference).

Specifically:

Here's a screenshot of blue-auto, under light mode:

Screenshot 2023-06-16 at 14 29 39

lynnpepin commented 1 year ago

Hey, many thanks for the contribution! It's a cool little feature, especially for people who don't prefer dark color themes 👍

The only remark I have code-wise is this: perhaps we could reduce the duplication between color-auto.scss (the dark version) and color.scss files somehow? It's essentially the same styles, but duplicated across 2 files, for each color. And that's not so great.

I'm not super familiar with Zola's SCSS preprocessing capabilities but perhaps you could find some way of including/inheriting the files. If not, don't worry -- just let me know and I'll merge as-is.

Sadly, I poked at this a bit when working on the PR, but I couldn't get it working. I don't know much about Zola's internals or how to take advantage of SCSS (compared to regular old CSS.)

But I'm sure it's possible, and I plan to keep using Terminimal for awhile. If I figure it out, I will submit another PR!

pawroman commented 1 year ago

Sadly, I poked at this a bit when working on the PR, but I couldn't get it working. I don't know much about Zola's internals or how to take advantage of SCSS (compared to regular old CSS.)

OK, that's fine. Let's address that one missing semicolon I spotted after writing the original reply.

I also gave the default "auto" setting some thought and I think it would be best to make it an opt-in feature for the time being, e.g. revert the default colors to what they were.

Rationale: With 250 stars, the theme seems to be getting quite popular (and I never expected this :sweat_smile:). I should really adopt some kind of release/versioning process and then such changes could be clearly communicated. Until then, I think it's best to avoid random breakage/unexpected changes for our users.

lynnpepin commented 1 year ago

Both were oversights on my part, thank you for pointing them out! Both should be fixed. I also updated the comments in theme.toml and the examples in README.md to reflect the changes to config.toml.

I'm a big fan of the original and this adaptation. Congrats on the 250 stars! :)

pawroman commented 1 year ago

Great stuff, thanks for the contribution!