paws-r / paws

Paws, a package for Amazon Web Services in R
https://www.paws-r-sdk.com
Other
318 stars 37 forks source link

Undo sub categories #593

Closed davidkretch closed 1 year ago

davidkretch commented 1 year ago
davidkretch commented 1 year ago

cc @DyfanJones

codecov[bot] commented 1 year ago

Codecov Report

Base: 84.61% // Head: 84.45% // Decreases project coverage by -0.16% :warning:

Coverage data is based on head (ded9667) compared to base (7147cf8). Patch has no changes to coverable lines.

:exclamation: Current head ded9667 differs from pull request most recent head 72a2f64. Consider uploading reports for the commit 72a2f64 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #593 +/- ## ========================================== - Coverage 84.61% 84.45% -0.16% ========================================== Files 126 63 -63 Lines 8091 4060 -4031 ========================================== - Hits 6846 3429 -3417 + Misses 1245 631 -614 ``` | [Impacted Files](https://codecov.io/gh/paws-r/paws/pull/593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paws-r) | Coverage Δ | | |---|---|---| | [paws/make.paws/R/docs.R](https://codecov.io/gh/paws-r/paws/pull/593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paws-r#diff-cGF3cy9tYWtlLnBhd3MvUi9kb2NzLlI=) | `92.50% <0.00%> (-1.85%)` | :arrow_down: | | [...rs/runner/work/paws/paws/paws.common/R/signer\_v4.R](https://codecov.io/gh/paws-r/paws/pull/593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paws-r#diff-VXNlcnMvcnVubmVyL3dvcmsvcGF3cy9wYXdzL3Bhd3MuY29tbW9uL1Ivc2lnbmVyX3Y0LlI=) | | | | [Users/runner/work/paws/paws/paws.common/R/client.R](https://codecov.io/gh/paws-r/paws/pull/593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paws-r#diff-VXNlcnMvcnVubmVyL3dvcmsvcGF3cy9wYXdzL3Bhd3MuY29tbW9uL1IvY2xpZW50LlI=) | | | | [Users/runner/work/paws/paws/paws.common/R/net.R](https://codecov.io/gh/paws-r/paws/pull/593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paws-r#diff-VXNlcnMvcnVubmVyL3dvcmsvcGF3cy9wYXdzL3Bhd3MuY29tbW9uL1IvbmV0LlI=) | | | | [...ers/runner/work/paws/paws/make.paws/R/sdk\_helper.R](https://codecov.io/gh/paws-r/paws/pull/593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paws-r#diff-VXNlcnMvcnVubmVyL3dvcmsvcGF3cy9wYXdzL21ha2UucGF3cy9SL3Nka19oZWxwZXIuUg==) | | | | [...sers/runner/work/paws/paws/make.paws/R/templates.R](https://codecov.io/gh/paws-r/paws/pull/593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paws-r#diff-VXNlcnMvcnVubmVyL3dvcmsvcGF3cy9wYXdzL21ha2UucGF3cy9SL3RlbXBsYXRlcy5S) | | | | [Users/runner/work/paws/paws/make.paws/R/text.R](https://codecov.io/gh/paws-r/paws/pull/593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paws-r#diff-VXNlcnMvcnVubmVyL3dvcmsvcGF3cy9wYXdzL21ha2UucGF3cy9SL3RleHQuUg==) | | | | [...sers/runner/work/paws/paws/paws.common/R/xmlutil.R](https://codecov.io/gh/paws-r/paws/pull/593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paws-r#diff-VXNlcnMvcnVubmVyL3dvcmsvcGF3cy9wYXdzL3Bhd3MuY29tbW9uL1IveG1sdXRpbC5S) | | | | [Users/runner/work/paws/paws/make.paws/R/docs.R](https://codecov.io/gh/paws-r/paws/pull/593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paws-r#diff-VXNlcnMvcnVubmVyL3dvcmsvcGF3cy9wYXdzL21ha2UucGF3cy9SL2RvY3MuUg==) | | | | [...nner/work/paws/paws/paws.common/R/credential\_sts.R](https://codecov.io/gh/paws-r/paws/pull/593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paws-r#diff-VXNlcnMvcnVubmVyL3dvcmsvcGF3cy9wYXdzL3Bhd3MuY29tbW9uL1IvY3JlZGVudGlhbF9zdHMuUg==) | | | | ... and [54 more](https://codecov.io/gh/paws-r/paws/pull/593?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paws-r) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paws-r). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paws-r)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

DyfanJones commented 1 year ago

did you apply the shortened r documentation name (hard to tell :P)

davidkretch commented 1 year ago

I still have to do that. Will get to it later today.

On Jan 28, 2023, at 11:21 AM, Larefly @.***> wrote:

 did you apply the shortened r documentation name (hard to tell :P)

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

DyfanJones commented 1 year ago

Sorry for my naive question, @davidkretch is the shortened r documentation going to be apart of this PR or the next?

davidkretch commented 1 year ago

Sorry it’s going to be in this one. I haven’t pushed it to GitHub yet.

On Jan 30, 2023, at 9:50 AM, Larefly @.***> wrote:

 Sorry for my naive question, @davidkretch is the shortened r documentation going to be apart of this PR or the next?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

davidkretch commented 1 year ago

@DyfanJones this should be ready to go.

DyfanJones commented 1 year ago

Perfect I will merge, and run the rhub tests before releasing :)