Issue 631/Support for STS regional endpoint config

joakibo commented 1 year ago

Attempts to fix #631 . No testing done, needs input from R experts on the general strategy and placement of code.

Remove hardcoded region for STS service when used in backend
Add functions in config.R which will check the STS Regional Endpoints envvar + config file
Dynamic endpoints list for the STS service, metadata endpoints is updated when STS client is initiated

DyfanJones commented 1 year ago

I think I am understanding this issue a little better, I believe we need to create custom_sts.R script similar to https://github.com/paws-r/paws/blob/main/paws.common/R/custom_s3.R so that only sts methods are affect. Will have a better look at this tomorrow :)

joakibo commented 1 year ago

Sounds good, thanks. Having it in this custom script makes sense. I don’t have a good understanding of the code base, easier for you to deduce where things should go 👍

Changes outlined here should at least be sufficient as I see it.

DyfanJones commented 1 year ago

@joakibo I believe we are in a good place with this. Will need to create some unit tests to fully test out the functionality. But I think it is nearly done. Please feel free to test it out and let me know

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.34 :warning:

Comparison is base (2aabd00) 84.07% compared to head (690625c) 83.73%.

:exclamation: Current head 690625c differs from pull request most recent head f5ef96d. Consider uploading reports for the commit f5ef96d to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #636 +/- ## ========================================== - Coverage 84.07% 83.73% -0.34% ========================================== Files 63 63 Lines 4214 4305 +91 ========================================== + Hits 3543 3605 +62 - Misses 671 700 +29 ``` [see 126 files with indirect coverage changes](https://app.codecov.io/gh/paws-r/paws/pull/636/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paws-r)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

joakibo commented 1 year ago

Thanks a lot @DyfanJones, looking forward to apply this fix on our side. Sorry for not being able to test this and assist more.

paws-r / paws

Issue 631/Support for STS regional endpoint config #636

Codecov Report