Closed DyfanJones closed 1 year ago
@davidkretch What's your view on this? I am just toying around with this idea so not tied to it as of yet.
Patch coverage has no change and project coverage change: -0.23
:warning:
Comparison is base (
71c6594
) 83.88% compared to head (fe8384c
) 83.66%.:exclamation: Current head fe8384c differs from pull request most recent head c3fb7d8. Consider uploading reports for the commit c3fb7d8 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
After discussion in https://github.com/paws-r/paws/issues/421 will go for proposal 1. As it helps with auto-complete when initialising service.
svc <- acm(
config = list(),
credentials = list(
creds = list(
access_key_id = "string",
secret_access_key = "string",
session_token = "string"
),
profile = "string"
),
endpoint = "string",
region = "string"
)
Initial idea for flattening the config list for initialising services (ticket: https://github.com/paws-r/paws/issues/421)
proposal 2
Downside: Doesn't help with auto-complete as the short hand utilises
...
instead of individual parameters.Upside: Allows the short hand method to keep up to date with any parameters that get added to the paws.common backend.