paws-r / paws

Paws, a package for Amazon Web Services in R
https://www.paws-r-sdk.com
Other
314 stars 37 forks source link

signature version: generate presigned url #646

Closed DyfanJones closed 1 year ago

DyfanJones commented 1 year ago

This PR allows the signature version to be changed for the method: generate_presigned_url

Ticket: https://github.com/paws-r/paws/issues/645

library(paws.common)

s3 = paws::s3(config(signature_version = "s3v4"))

s3$generate_presigned_url("list_objects", params = list(Bucket = "my-bucket"))

This should replicate boto3 implementation:

import boto3
from botocore.config import Config

s3 = boto3.client("s3", config = Config(signature_version = "s3v4"))

s3.generate_presigned_url("list_objects", Params = {"Bucket" : "my-bucket"})
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.02 :warning:

Comparison is base (4ef8488) 83.62% compared to head (f2c264b) 83.61%.

:exclamation: Current head f2c264b differs from pull request most recent head 2ff3577. Consider uploading reports for the commit 2ff3577 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #646 +/- ## ========================================== - Coverage 83.62% 83.61% -0.02% ========================================== Files 65 195 +130 Lines 4404 13216 +8812 ========================================== + Hits 3683 11051 +7368 - Misses 721 2165 +1444 ``` [see 134 files with indirect coverage changes](https://app.codecov.io/gh/paws-r/paws/pull/646/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paws-r)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.