paws-r / paws

Paws, a package for Amazon Web Services in R
https://www.paws-r-sdk.com
Other
314 stars 37 forks source link

Initial paginate function #650

Closed DyfanJones closed 1 year ago

DyfanJones commented 1 year ago

This PR adds the following features:

library(paws.storage)

svc <- s3(confg())

paginate(
    svc$list_objects_v2(Bucket = "made-up")
)
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.21% :tada:

Comparison is base (88f32dd) 83.55% compared to head (9f16a7f) 83.76%. Report is 1 commits behind head on main.

:exclamation: Current head 9f16a7f differs from pull request most recent head 504e7db. Consider uploading reports for the commit 504e7db to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #650 +/- ## ========================================== + Coverage 83.55% 83.76% +0.21% ========================================== Files 195 198 +3 Lines 13216 13819 +603 ========================================== + Hits 11042 11576 +534 - Misses 2174 2243 +69 ``` [see 42 files with indirect coverage changes](https://app.codecov.io/gh/paws-r/paws/pull/650/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paws-r)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DyfanJones commented 1 year ago

I believe we are at a good point. All paginate information is passed from json file to paws so that we can build paginate queries correctly instead of guessing them. Next step will be to add unit tests.

edgBR commented 1 year ago

Hi,

I am no longer using paws but wow, this is a great PR