search

paws-r / paws

Paws, a package for Amazon Web Services in R
https://www.paws-r-sdk.com
Other
313 stars 37 forks source link

docs: `endpoint` & `region` in config, not credentials #678

Closed dpprdan closed 11 months ago

dpprdan commented 11 months ago

IIUC endpoint and region ought to items of config, not config.credentials

DyfanJones commented 11 months ago

Ah thanks for the PR. I really appreciate it :) paws is a big beast and keep on top can be difficult at times :) I will review this when I get back from my holiday :)

codecov[bot] commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (7bf9569) 84.07% compared to head (89ad8bf) 84.06%.

:exclamation: Current head 89ad8bf differs from pull request most recent head 50dc937. Consider uploading reports for the commit 50dc937 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #678 +/- ## ========================================== - Coverage 84.07% 84.06% -0.02% ========================================== Files 134 134 Lines 9615 9614 -1 ========================================== - Hits 8084 8082 -2 - Misses 1531 1532 +1 ``` [see 135 files with indirect coverage changes](https://app.codecov.io/gh/paws-r/paws/pull/678/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paws-r)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.